Resolver2 #6434
Draft
Resolver2 #6434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 7, 2025 09:15
✅ Deploy Preview for reliable-cocada-166884 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…n.lock working, package-lock needs investigation
Lock files (yarn.lock, package-lock.json) are now reloaded fresh each time a package version needs to be resolved. This ensures that changes to lock files during the session are picked up immediately. Previously, lock files were parsed once during ImportResolver initialization and cached. If a user added or modified a lock file, the stale cached versions would be used, causing the wrong package version to be resolved. Changes: - Clear lockFileVersions map before each reload - Call loadLockFileVersions() in resolvePackageVersion() before checking cache - This has minimal overhead as lock files are small text files
Added comprehensive tests for lock file version resolution: Group 5 (yarn.lock): - Test initial yarn.lock resolution (4.9.6) - Test yarn.lock change detection (4.9.6 → 4.7.3) Group 6 (package-lock.json): - Test initial package-lock.json resolution (4.8.1) - Test package-lock.json change detection (4.8.1 → 4.6.0) Both test groups verify that: 1. Lock file versions are used correctly 2. Changes to lock files are picked up immediately 3. Re-compilation uses the new version from updated lock file Tests delete .deps folder between compilations to force fresh resolution, demonstrating that the ImportResolver now reloads lock files dynamically.
Updated lock file change detection tests to properly modify existing files: - Use openFile() to open the lock file - Use setEditorValue() to change its content - Use right-click + delete menu to remove .deps folder (instead of execute()) This follows the standard pattern used in other E2E tests like code_format.test.ts and ensures the file modification is properly handled by the file manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.